fix(web): disable untruthful agent views - #145
Merged
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Author
|
Deployed verification (secret-free):
|
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
agentUiSurfacesEnabled=trueclient preference.t3_show_uicalls as ordinary collapsed tool rows and keep expanded state closed.Why
Deployed verification disproved the premise behind PR #144's iframe isolation. A fresh top-level room load reconstructed the expected live scene after browser storage was cleared, but ordinary and credentialless iframes did not join the room. The ordinary frame could display an older origin-local scene; the credentialless frame displayed empty isolated storage.
The exact deployed source map sets collaboration disabled whenever the app is running in an iframe. Its scene initialization starts room collaboration only when a collaboration API exists, so no generic bkt3 iframe policy can make the URL-selected room load truthfully. A redacted Chrome trace also confirmed that the child received the exact stored URL and its non-empty fragment; URL loss and redirects are ruled out.
The safe bkt3-only response is fail-closed. This does not special-case a domain, rewrite fragments, proxy bearer keys, or weaken sandbox isolation. Restoring truthful inline live-room behavior requires a change in the embedded collaboration app or a different browser integration.
UI Changes
Before: a URL Agent view could show stale origin-local content or an empty canvas while appearing to represent the requested room.
After: Agent views do not mount. Settings shows the switch disabled, and existing calls remain ordinary tool rows. A long-lived tab still running the prior JavaScript must hard-refresh once to load this mitigation.
The live before-state was verified without capturing or exposing room fragments. Post-deploy evidence will be added after the experimental artifact is installed.
Verification
apps/web: 9 focused surface/runtime DOM tests passed.apps/server: 147 focused Agent UI and static-router tests passed.apps/desktop: 8 focused protocol/header tests passed.apps/web: package typecheck passed.Checklist
Written by GPT-5.6-Sol in T3 Code (Codex harness).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.