fix(desktop): add the new client setting to the settings round-trip fixture - #140
Merged
Conversation
…ixture `ClientSettings` is exhaustive, so adding `agentUiSurfacesEnabled` broke the desktop persistence test that builds a whole settings object by hand. Written by Claude Opus 5 in T3 Code.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
The repo's Effect lint rules reject `crypto.randomUUID()` inside Effect code — it bypasses Effect-injected randomness. Use the same `Crypto.randomUUIDv4` pattern PlanReviewService uses, where a failing CSPRNG is a defect rather than a recoverable error. Written by Claude Opus 5 in T3 Code.
Written by Claude Opus 5 in T3 Code.
The catalog derives one virtual MCP tool per websocket RPC, and two tests pin the total. Adding `agentUi.getRender` moves it from 137 to 138; `matchedCount` moves with it, so the new RPC generates a complete schema like the rest. Written by Claude Opus 5 in T3 Code.
Embedding a URL without `allow-same-origin` gives the document an opaque origin, so localStorage, IndexedDB and cookies all throw. Every real app fails to boot that way — a self-hosted Excalidraw canvas among them — which made the `url` half of agent views useless in practice. Grant it, except when the framed URL is same-origin with the page itself. `allow-scripts` plus `allow-same-origin` is a sandbox escape only in that case, where the frame could reach our DOM and the signed-in session directly; a self-referential embed stays opaque and harmless instead. Written by Claude Opus 5 in T3 Code.
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #139, which merged with
CheckandTestred.ClientSettingsis exhaustive, so addingagentUiSurfacesEnabledbroke the oneplace that builds a whole settings object by hand — the desktop persistence
round-trip test. Both failing jobs were this single fixture.
apps/desktoptypechecks clean and the suite passes locally (7/7). Checked forother exhaustive fixtures; this was the only one.
Written by Claude Opus 5 in T3 Code.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.