Skip to content

fix(desktop): add the new client setting to the settings round-trip fixture - #140

Merged
tusharbhardwaj-bk merged 5 commits into
expbkmainfrom
t3code/mechoui
Aug 28, 2026
Merged

fix(desktop): add the new client setting to the settings round-trip fixture#140
tusharbhardwaj-bk merged 5 commits into
expbkmainfrom
t3code/mechoui

Conversation

@tusharbhardwaj-bk

@tusharbhardwaj-bk tusharbhardwaj-bk commented Aug 28, 2026

Copy link
Copy Markdown

Follow-up to #139, which merged with Check and Test red.

ClientSettings is exhaustive, so adding agentUiSurfacesEnabled broke the one
place that builds a whole settings object by hand — the desktop persistence
round-trip test. Both failing jobs were this single fixture.

apps/desktop typechecks clean and the suite passes locally (7/7). Checked for
other exhaustive fixtures; this was the only one.

Written by Claude Opus 5 in T3 Code.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…ixture

`ClientSettings` is exhaustive, so adding `agentUiSurfacesEnabled` broke the
desktop persistence test that builds a whole settings object by hand.

Written by Claude Opus 5 in T3 Code.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 15.1 KiB
Codex Thread snapshot wire 7.2 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.4 KiB 7.8 KiB
Codex Live turn WebSocket decoded 55.7 KiB 66.4 KiB
Codex Live turn messages 11 21
Claude Total thread wire 13.6 KiB 15.1 KiB
Claude Thread snapshot wire 7.2 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.4 KiB 7.8 KiB
Claude Live turn WebSocket decoded 56.5 KiB 66.4 KiB
Claude Live turn messages 11 21

Baseline: unavailable · PR result: e8c5d5e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 110.4 KiB
  • Claude decoded thread snapshot: 111.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

The repo's Effect lint rules reject `crypto.randomUUID()` inside Effect code —
it bypasses Effect-injected randomness. Use the same `Crypto.randomUUIDv4`
pattern PlanReviewService uses, where a failing CSPRNG is a defect rather than a
recoverable error.

Written by Claude Opus 5 in T3 Code.
Written by Claude Opus 5 in T3 Code.
The catalog derives one virtual MCP tool per websocket RPC, and two tests pin
the total. Adding `agentUi.getRender` moves it from 137 to 138; `matchedCount`
moves with it, so the new RPC generates a complete schema like the rest.

Written by Claude Opus 5 in T3 Code.
Embedding a URL without `allow-same-origin` gives the document an opaque origin,
so localStorage, IndexedDB and cookies all throw. Every real app fails to boot
that way — a self-hosted Excalidraw canvas among them — which made the `url`
half of agent views useless in practice.

Grant it, except when the framed URL is same-origin with the page itself.
`allow-scripts` plus `allow-same-origin` is a sandbox escape only in that case,
where the frame could reach our DOM and the signed-in session directly; a
self-referential embed stays opaque and harmless instead.

Written by Claude Opus 5 in T3 Code.
@github-actions github-actions Bot added size:M and removed size:XS labels Aug 28, 2026
@tusharbhardwaj-bk
tusharbhardwaj-bk merged commit b5cb152 into expbkmain Aug 28, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant