feat(web): show the owner's avatar on sessions someone else started - #135
Merged
Conversation
In a shared environment the experimental sidebar mixes my own sessions with the ones teammates started and tagged me into, and the rows looked identical — you had to open a thread to learn whose it was. Thread rows now carry the owner's avatar immediately left of the provider icon, but only when the owner is someone other than the current operator: my own face on every row of my own sidebar would carry no information. Unowned threads (single-user mode, awaiting backfill) and sessions with no team identity show nothing, so nothing changes outside team mode. The decision lives in `phaseSidebarRowOwnerAvatarUserId`, and the avatar is a new fork-owned component that only subscribes to the org directory on the rows that actually render one. Claude Opus 5 via Claude Code in T3 Code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a shared environment the experimental sidebar mixes my own sessions with the ones teammates started and tagged me into, and the rows look identical. Whose session a row is was only discoverable by opening the thread.
Fix
Thread rows now carry the owner's avatar immediately left of the provider icon, in the same bottom-right lane as the priority badge — but only when the owner is someone other than the current operator. My own face on every row of my own sidebar would carry no information.
Nothing renders when:
ownerUserId === null— single-user mode, or awaiting backfill), orSo this is a no-op outside team mode.
Shape of the change:
phaseSidebarRowOwnerAvatarUserIdinPhaseGroupedSidebar.logic.ts— the pure "whose face, if anyone's" decision, unit-tested.sidebar/PhaseSidebarOwnerAvatar.tsx— new fork-owned component, split into a presentational view (asserted with static markup) and a thin connected wrapper. Rendered only when the helper returns a user id, so rows that need no avatar never subscribe to the org directory and the memo'd row keeps comparing by value.resolveUser, so a row never shows a hole.Verification
vp test runon the two touched test files — 82 passed.tsgo --noEmitfor@t3tools/web— clean.vp lintandvp fmton the changed files — clean.node scripts/check-fork-markers.ts— passed.No before/after images: capturing them needs a browser session on the shared dev server, which was not authorised for this change. The rendered result is verified on expbkt3 after deploy, which is what this branch targets.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.