change resolution on fly #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is also necessary to send the SPS\PPS along with the keyframe, in addition to the AVCSequenceHeader Now all players do not freeze and change resolution anywhere in the stream! Tested: PotPlayer, MPC (hard accel\soft), Chrome, Forefox, FFplay (also with h264_qsv decoder) See begeekmyfriend#832
|
You have solved the issue you shot on your own. Trust you! |
|
How correct is it also to send an AVCSequenceHeader before a NAL (SPS\PPS\IDR) in the middle of a stream? There are no errors, moreover, the SRS server updates it and at the beginning of the stream (new client) sends the current AVCSequenceHeader to the client. This helps to quickly start the stream and not send SPS\PPS together with IDR every time. My other implementation of encoder (webrtc -> rtmp -> SRS -> HttpFLV ) sends with IDR every time SPS\PPS. but does not send AVCSequenceHeader in the middle stream. Therefore, the client has to wait for the IDR from the SPS. Yes, you can cache GOP on the server side,, but it also slows down playback at the beginning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is also necessary to send the SPS\PPS along with the keyframe, in addition to the AVCSequenceHeader
Now all players do not freeze and change resolution anywhere in the stream!
Tested: PotPlayer, MPC (hard accel\soft), Chrome, Forefox, FFplay (also with h264_qsv decoder)
See
#832