fix C2 may not send during rtmp handshake #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a tiny issue when I publish a live stream via yasea a on my local side, the NG summary packet like below:
742 2018/004 10:49:45.372509 172.16.66.20 172.16.110.30 RTMP 131 Handshake C0+C1
743 2018/004 10:49:45.372639 172.16.110.30 172.16.66.20 TCP 54 1935 → 47493 [ACK] Seq=1 Ack=1538 Win=65536 Len=0
744 2018/004 10:49:45.372941 172.16.110.30 172.16.66.20 TCP 1514 1935 → 47493 [ACK] Seq=1 Ack=1538 Win=65536 Len=1460
745 2018/004 10:49:45.372962 172.16.110.30 172.16.66.20 TCP 1514 1935 → 47493 [ACK] Seq=1461 Ack=1538 Win=65536 Len=1460
746 2018/004 10:49:45.372970 172.16.110.30 172.16.66.20 RTMP 207 Handshake S0+S1+S2
747 2018/004 10:49:45.375596 172.16.66.20 172.16.110.30 TCP 60 47493 → 1935 [ACK] Seq=1538 Ack=1461 Win=90624 Len=0
748 2018/004 10:49:45.376978 172.16.66.20 172.16.110.30 TCP 60 47493 → 1935 [ACK] Seq=1538 Ack=2921 Win=93440 Len=0
749 2018/004 10:49:45.377756 172.16.66.20 172.16.110.30 TCP 60 47493 → 1935 [ACK] Seq=1538 Ack=3074 Win=93440 Len=0
750 2018/004 10:49:45.380986 172.16.66.20 172.16.110.30 TCP 1514 47493 → 1935 [ACK] Seq=1538 Ack=3074 Win=93440 Len=1460
751 2018/004 10:49:45.380991 172.16.66.20 172.16.110.30 RTMP 399 connect('teach_app')
C2 packet seems to disappear. the reason that I think it's a tiny issue is the rtmp Netconnection and NetStream can setup successfully.