Merge pull request #2396 from HalfWhitt/getattr

Simplifying static getattr calls

changes/2396.misc.rst

@@ -0,0 +1 @@
+getattr calls with string literals for attr have been collapsed to dot lookup.

testbed/tests/conftest.py

@@ -40,7 +40,7 @@ def app():
 @fixture
 async def app_probe(app):
     module = import_module("tests_backend.app")
-    probe = getattr(module, "AppProbe")(app)
+    probe = module.AppProbe(app)
 
     if app.run_slow:
         print("\nConstructing app probe")
@@ -62,7 +62,7 @@ async def main_window_probe(app, main_window):
     module = import_module("tests_backend.window")
     if app.run_slow:
         print("\nConstructing Window probe")
-    yield getattr(module, "WindowProbe")(app, main_window)
+    yield module.WindowProbe(app, main_window)
 
     main_window.content = old_content
 

testbed/tests/test_fonts.py

@@ -28,7 +28,7 @@ async def font_probe(main_window, widget):
     main_window.content = box
 
     module = import_module("tests_backend.widgets.label")
-    probe = getattr(module, "LabelProbe")(widget)
+    probe = module.LabelProbe(widget)
     await probe.redraw("\nConstructing Font probe")
     probe.assert_container(box)
 

testbed/tests/test_icons.py

@@ -8,7 +8,7 @@
 
 def icon_probe(app, image):
     module = import_module("tests_backend.icons")
-    return getattr(module, "IconProbe")(app, image)
+    return module.IconProbe(app, image)
 
 
 async def test_icon(app):

testbed/tests/test_images.py

@@ -12,7 +12,7 @@
 
 def image_probe(app, image):
     module = import_module("tests_backend.images")
-    return getattr(module, "ImageProbe")(app, image)
+    return module.ImageProbe(app, image)
 
 
 async def test_local_image(app):

testbed/tests/test_window.py

@@ -17,7 +17,7 @@
 
 def window_probe(app, window):
     module = import_module("tests_backend.window")
-    return getattr(module, "WindowProbe")(app, window)
+    return module.WindowProbe(app, window)
 
 
 @pytest.fixture