Add ObjCProtocol class #76
Conversation
Currently this only supports looking up and inspecting protocols, not creating new ones.
|
OK, this is mostly done now. At the moment flake8 complains about |
There was a problem hiding this comment.
As always, very little to fault here from a technical perspective.
One thing I'd like to see before we merge is some documentation. We haven't historically required docs before merging new features, but we need to get on top of this before we've got a monster project with no docs.
I've just addressed the review notes on #67; if we can get that merged in, you can add a quick set of explanatory notes as a new how-to document, and we can merge this in!
| results = {} | ||
|
|
||
| class Handler(NSObject): | ||
| class Handler(NSObject, protocols=[Callback]): |
There was a problem hiding this comment.
Nice usage of metaclass kwargs.
There was a problem hiding this comment.
Yep, they are really useful for this sort of thing. I didn't want to do it this way originally - first I tried to put the protocols directly in the bases list (after the base class), but Python didn't like that, because the superclass has a different metaclass (ObjCClass) than the protocols (ObjCProtocol). In the end this way is probably best though, it's easier to read and cleaner to implement.
|
Agreed about the documentation - I didn't really think much about that yet, but it is a good idea to document new features right away. |
|
Alright, I finally got this done, sorry for the delay - real life was a bit busier than expected. I'm not sure why the Travis build hasn't started yet, but tox ran without issues for me locally, so everything should be fine. |
# Conflicts: # docs/how-to/index.rst
Implements parts of #69.
This adds an
ObjCProtocolclass similar toObjCClass, which supports basic introspection (name and superprotocols).ObjCClasses now also have aprotocolsproperty to look up which protocols are adopted.Creating custom protocols and adopting protocols in Python is not yet supported, I'm working on that next.