-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance web ui search #3610
Enhance web ui search #3610
Conversation
This is a pretty basic PR which adds three buttons for new search modes. The basic idea is to prepend `artist:` or `album:` to the query string for the user. An `all` button is added to avoid confusion around a general search. While a manual search is possible this makes a qualified search more natural.
Related issue |
Hmm—I see what you're going for here, but I also kind of like the transparency of the current model where what you're typing is just a plain old beets query. It also seems a little odd that I do think there are probably interesting ways to think about querying by artist and album, but I'm not sure query prefixes are the right one. We probably want to do something like the equivalent of |
That's fair. That could be fixed to query on artist'foo bar', but I get the sense that you're not a fan on the buttons either way. I agree that it's a bit ugly for what it's worth :)
That would be ideal I think, but I'm not sure how to map that to the UI. The list of results from the query seemed to only work with tracks when I was testing things. I could extend the results listing to handle album entries as well, but I see a few issues there
|
Yeah, I indeed think that's the hard part—the UI for albums might want to be quite different from the UI for individual tracks! I don't have any great answers here, but I continue to be excited to unleash this kind of creative thinking by supporting alternative web UIs… |
Let me ask a different question then; where do you see the limits of the current interface? I completely understand that by making this PR I am asking you to take on the maintenance burden of supporting new features and I want to respect that you might not want to maintain my crap. So, are you open to UI changes in the default web UI? If so what bounds on complexity (hard or soft) are you open to? |
That's a great question, and I don't have a 100% solid answer. On one hand, I think it would be cool to add features that don't take away from the bare-bones simplicity. On the other hand, I want to channel this energy in making better UIs in the bright AURA-powered future where we can have lots of different UIs—simple ones, complex ones, weird ones—all developed independently and interoperable, rather than having the "one true UI" that is blessed by the beets distribution. So that's not really a useful answer, I suppose, but maybe it gives some insight into roughly what's on my mind? But of course I'm just one person in the vast beets hivemind… it can always be nice to hear from others about what would be good to see, or to try getting folks to weigh in on the Discourse. |
After reading through the discourse a bit I think that's probably the place to have the conversation. Thanks and I'll close this PR. |
This is a pretty basic PR which adds three buttons for new search modes.
The basic idea is to prepend
artist:
oralbum:
to the query string for the user.An
all
button is added to avoid confusion around a general search.While a manual search is possible this makes a qualified search more natural.