Fetch original_year from master releases for Discogs (#1122) #2893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional Discogs API call from inside get_album_info() via a very basic fetch method (it only returns year). This may be expanded in the future to fetch other fields from the master release (genres, styles, etc.) if necessary.
Assume that
original_year
equals toyear
for releases without a master release. If parsing the original year in the master release fails, the resulting value is kept asNone
.I am not sure how to update tests, because the API call is inside
get_album_info
. The functionality is so basic that possibly it is not necessary (and other API calls aren't tested as well).