Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Python 3.4 with 3.6 on Appveyor #2358

Merged
1 commit merged into from Jan 3, 2017
Merged

Replace Python 3.4 with 3.6 on Appveyor #2358

1 commit merged into from Jan 3, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2016

Python 3.4 is quite old and offers little value on Windows.

Closes #2344

@ghost
Copy link
Author

ghost commented Dec 31, 2016

looks like we've been bitten by this bug http://bugs.python.org/issue29097

@sampsyo
Copy link
Member

sampsyo commented Dec 31, 2016

Wow; that's a pretty crazy bug. 😕 So I suppose we have to wait for 3.6.1, or skip those tests for now? (Occasionally, CI can seem like more of a headache than it's worth.)

@sampsyo
Copy link
Member

sampsyo commented Dec 31, 2016

Or we can find a way to avoid running datetime.fromtimestamp(0) in _to_epoch_time by using some other method to subtract off the system epoch?

sampsyo added a commit that referenced this pull request Jan 2, 2017
This also works around a bug in Python 3.6.0 on Windows: see #2358.
Python 3.4 is quite old and offers little value on Windows.

Closes #2344
@ghost ghost merged commit bd340b2 into beetbox:master Jan 3, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant