Finally started to get somewhere :-) #1

nateroling · 2011-02-18T12:44:14Z

I finally got around to cleaning up the ImportTest I wrote.

I haven't merged your latest commit, because I'm not 100% sure the best way to handle that. I don't want to do it as a rebase, I don't think. I imagine I just want to merge your changes in. Let me know if you want me to do that before you pull my commits in. I'm sure GitHub has a very nice tutorial on it somewhere that I can read. I should get around to reading the Git Book at some point.

Anyway, let me know what you think.

Tracks could be deleted when re-importing tracks that are already in the library directory and import_delete is set to yes.

BaseAlbum needs to use object.setattr in its __init__ method, because it overrides __setattr__.

test_library.py so far just documents existing behavior of album objects, especially the fact that trying to access unset fields causes an AttributeError.

If the track.albumartist isn't set on the first track, then the album.albumartist is set to the track.artist.

Only tests "as-is" metadata imports, making sure that tracks are copied to the library and named properly.

nateroling · 2011-02-18T12:50:27Z

I went ahead and merged in your last commit. It seems like the right thing to do:
http://help.github.com/forking/

sampsyo · 2011-02-18T20:44:38Z

Hey, thanks! This test looks great. I'm glad someone's finally gotten around to writing good integration tests for the importer -- that's good peace of mind.

I'm pushing your changes to the main repository with a couple of changes.

Moved tests from test_album to test_db (alongside the rest of the tests for albums).
Changed some things about how artists (and now artist IDs) are "guessed" from files that don't have them. This behavior is, for example, only enabled for "as-is" imports.
Reorganize the test class a little bit for reusability.
I also added the ability to disable the "progress" (.beetsstate file) functionality for testing.

Let me know if I messed anything up. Thanks again for your help!

(BTW, in the future, I also don't mind doing the merge on my end when I pull in your changes.)

nateroling · 2011-02-19T04:49:53Z

It all looks golden to me :-)

This is, shockingly, the #1 question I get asked. I hope this helps.

This was well-intentioned but ended up being more confusing than it was worth. It's always confused me when one digit gets un-highlighted in one of these displays. The straw that broke the camel's back was when I got a "#1 -> #16" change where the numeral "1" was un-highlighted. To fix this right would be way more trouble than it's worth; I'm glad to be rid of this detail.

This was well-intentioned but ended up being more confusing than it was worth. It's always confused me when one digit gets un-highlighted in one of these displays. The straw that broke the camel's back was when I got a "#1 -> #16" change where the numeral "1" was un-highlighted. To fix this right would be way more trouble than it's worth; I'm glad to be rid of this detail. Conflicts: docs/changelog.rst

Update the fork

fixes issue beetbox#3346: For (hidden) tracks with index 0, the UI would previously show a #0 -> beetbox#1 change when actually the index would be set to 0. Now, properly distinguish index 0 and None (i.e. not set)

fixes issue beetbox#3346: When the per_disc_numbering option was set, the UI would previously show a #0 -> beetbox#1 change when actually the index would be set to 0 (a valid index, such as for hidden tracks). Now, properly distinguish index 0 and None (i.e. not set)

Sort and categorize config_default.yaml

Fixes #5148. When importing, the code that matches tracks does not consider the medium number. This causes problems on Hybrid SACDs (and other releases) where the artists, track numbers, titles, and lengths are the same on both layers. I added a distance penalty for mismatching medium numbers. Before: ``` $ beet imp . /Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1 (6 items) Match (95.4%): The Red Garland Quintet - All Mornin' Long ≠ media, year MusicBrainz, 2xHybrid SACD (CD layer), 2013, US, Analogue Productions, CPRJ 7130 SA, mono https://musicbrainz.org/release/6a584522-58ea-470b-81fb-e60e5cd7b21e * Artist: The Red Garland Quintet * Album: All Mornin' Long * Hybrid SACD (CD layer) 1 ≠ (#2-1) All Mornin' Long (20:21) -> (#1-1) All Mornin' Long (20:21) ≠ (#2-2) They Can't Take That Away From Me (10:24) -> (#1-2) They Can't Take That Away From Me (10:27) ≠ (#2-3) Our Delight (6:23) -> (#1-3) Our Delight (6:23) * Hybrid SACD (CD layer) 2 ≠ (#1-1) All mornin' long (20:21) -> (#2-1) All Mornin' Long (20:21) ≠ (#1-2) They can't take that away from me (10:27) -> (#2-2) They Can't Take That Away From Me (10:25) ≠ (#1-3) Our delight (6:23) -> (#2-3) Our Delight (6:23) ➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums, Enter search, enter Id, aBort, eDit, edit Candidates? ``` Note that all tracks tagged with disc 1 get moved to disc 2 and vice versa. After: ``` $ beet-test imp . /Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1 (6 items) Match (95.4%): The Red Garland Quintet - All Mornin' Long ≠ media, year MusicBrainz, 2xMedia, 2013, US, Analogue Productions, CPRJ 7130 SA, mono https://musicbrainz.org/release/6a584522-58ea-470b-81fb-e60e5cd7b21e * Artist: The Red Garland Quintet * Album: All Mornin' Long * Hybrid SACD (CD layer) 1 ≠ (#1-1) All mornin' long (20:21) -> (#1-1) All Mornin' Long (20:21) ≠ (#1-2) They can't take that away from me (10:27) -> (#1-2) They Can't Take That Away From Me (10:27) ≠ (#1-3) Our delight (6:23) -> (#1-3) Our Delight (6:23) * Hybrid SACD (SACD layer) 2 * (#2-1) All Mornin' Long (20:21) * (#2-2) They Can't Take That Away From Me (10:24) * (#2-3) Our Delight (6:23) ➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums, Enter search, enter Id, aBort, eDit, edit Candidates? ``` Yay!

Ozzi Lee added 7 commits February 2, 2011 13:08

Fixed a bug where tracks could be deleted on re-import.

6baf9f5

Tracks could be deleted when re-importing tracks that are already in the library directory and import_delete is set to yes.

Log album.albumartist instead of album.artist after import.

c15c3ee

Use object.setattr in BaseAlbum __init__ method.

95a456a

BaseAlbum needs to use object.setattr in its __init__ method, because it overrides __setattr__.

Added a very basic test_library.py

d955474

test_library.py so far just documents existing behavior of album objects, especially the fact that trying to access unset fields causes an AttributeError.

Make sure album.albumartist is set when adding items to a Library.

82e5f0c

If the track.albumartist isn't set on the first track, then the album.albumartist is set to the track.artist.

Add ImportTest, testing import_files in commands.py.

9d20fd7

Only tests "as-is" metadata imports, making sure that tracks are copied to the library and named properly.

Merge remote branch 'upstream/master'

2dd4c0a

dimsuz mentioned this pull request Jul 13, 2013

Change permissions on moved files before writing #343

Closed

iluvdirt mentioned this pull request Jan 9, 2014

Problem with Lastgenre #490

Closed

ian-kelling mentioned this pull request Mar 12, 2014

duplicates: Default settings detect spurious duplicates when IDs are missing #586

Closed

sampsyo added a commit that referenced this pull request Mar 22, 2014

docs: emphasize that you create config.yaml

882d230

This is, shockingly, the #1 question I get asked. I hope this helps.

infinitescale mentioned this pull request Apr 18, 2014

Compatibility with old SQLite versions #694

Open

tlc mentioned this pull request Sep 4, 2014

Avoid needless field writes via dirty tracking in Item #656

Open

Kraymer mentioned this pull request Nov 29, 2014

Choosing "Use as-is" to resolve a match prevent the writing of tags via plugins #726

Open

AllYouNeedIsHeadcleaner mentioned this pull request Dec 1, 2014

"configuration error: import must be a collection, not unicode" #1125

Closed

Dosman mentioned this pull request Jan 26, 2015

'Write' command to update tags hangs on NAS drive #1268

Closed

yoasif mentioned this pull request Mar 20, 2015

TypeError: 'Subview' object is not iterable when running beet lastimport #1365

Closed

jeffkennedy5 mentioned this pull request Apr 24, 2015

Unable to find a Specific Release: Due to punctuation, maybe? #1437

Closed

eriwst mentioned this pull request Feb 8, 2016

lastimport: AttributeError: 'CustomUser' object has no attribute 'ws_prefix' #1875

Closed

zuzzurro mentioned this pull request Mar 23, 2016

import using pre-existing musicbrainz tags #1919

Closed

jbaiter mentioned this pull request Jun 20, 2016

Revive the Beatport plugin #1989

Closed

welch mentioned this pull request Dec 14, 2016

discogs: Match individual subtracks #2318

Closed

bearcatsandor mentioned this pull request Mar 10, 2017

absubmit: Do not filter on supported formats #2471

Closed

yacoob mentioned this pull request Apr 22, 2017

lastgenre fails during a full library run #2525

Closed

RollingStar mentioned this pull request May 14, 2017

Formatting function to ASCIIfy punctuation only #2558

Open

sampsyo pushed a commit that referenced this pull request Mar 7, 2018

Merge pull request #1 from beetbox/master

b6b25cf

Update the fork

ghost mentioned this pull request Mar 29, 2018

Does not Take my Input After First Album #2859

Closed

ryanakca mentioned this pull request Jun 2, 2018

File extension not added on ALAC/AAC-LC file after import #2941

Closed

hrehfeld mentioned this pull request Aug 19, 2018

beets bpd crash #3007

Closed

samuelnilsson mentioned this pull request Aug 3, 2019

replaygain ffmpeg backend: ffmpeg exited with status 1 #3341

Closed

InvisibleFunction mentioned this pull request Aug 17, 2019

Importer displays misleading info on album with track 0 #3346

Closed

Moonbase59 mentioned this pull request Sep 30, 2019

"Original date" is something different for albums and tracks! #3382

Closed

ScuttleSE mentioned this pull request Jun 6, 2020

Make "paths:" more user-friendly and expandable #3616

Closed

hamaryns mentioned this pull request Feb 20, 2022

Data loss when interrupting import #4283

Closed

JOJ0 mentioned this pull request Mar 16, 2022

musicbrainz: Support extra_tag discogs_catalog #4321

Closed

3 tasks

RollingStar mentioned this pull request Jul 25, 2023

Note linuxserver.io in getting started #4859

Closed

3 tasks

JOJ0 pushed a commit that referenced this pull request Dec 17, 2023

Merge pull request #1 from RollingStar/config_sort

ec3d9b9

Sort and categorize config_default.yaml

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Finally started to get somewhere :-) #1

Finally started to get somewhere :-) #1

nateroling commented Feb 18, 2011

nateroling commented Feb 18, 2011

sampsyo commented Feb 18, 2011

nateroling commented Feb 19, 2011

Finally started to get somewhere :-) #1

Finally started to get somewhere :-) #1

Conversation

nateroling commented Feb 18, 2011

nateroling commented Feb 18, 2011

sampsyo commented Feb 18, 2011

nateroling commented Feb 19, 2011