ftintitle: False positives in "feat. X" detection #5441
Comments
3 tasks
klb2
added a commit
to klb2/beets
that referenced
this issue
Sep 30, 2024
Add references to the ftintitle plugin for the bug fixes beetbox#5441 and beetbox#5436 that are related to this plugin.
snejus
added a commit
that referenced
this issue
Oct 1, 2024
Fixes #5441 This small change explicitly passes the `for_artist` keyword to the `plugins.feat_tokens` function that constructs the regex for matching existing "feat. X" parts in song titles. Previously, it was not passed and set to the default (`True`), which caused using the pattern intended for the artist field to also be used for the title field. This caused some false positives as shown in #5441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The
ftintitleplugin has thecontains_featfunction to check whether a given title already contains a "feat. X" part. The regex used for pattern matching is defined in thefeat_tokensfunction inbeets/plugins.py.In the default call of
feat_tokens(), this adds possiblefeat_wordslike "and" and "with". This can yield to false positives in the feature detection as shown in the following example:However, this is simply the title of the song and does not contain a "feat. X" part. (The "and" in the title is detected and matched in the regex.)
The consequence of this is that the
ftintitleplugin will actually not add the actual "feat. X" part to the title as it thinks it already contains one.Fix
I believe the issue is that in
ftintitle.contains_feat, the regex is constructed usingplugins.feat_tokens(), which setsfor_artist=True. A fix would be to change this toplugins.feat_tokens(for_artist=False)as we are matching song titles and not artist.Setup
masterbranch @ 1a59368The text was updated successfully, but these errors were encountered: