-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to turn off musicbrainz - only use spotify for tagging / candidates? #4605
Comments
For reference, the PR implementing the feature: #4319 |
@Emporea I just read through the feature PR which seems very thoroughly done and reviewed so just doublechecking: How did you install and verify you are using the current state of dev? Maybe post some pip outputs etc just to make sure it's not a kind of python/venv/install whatever oversight. |
I realised that singleton imports indeed still fetch from MusicBrainz even if disabled on config.. I'll post details and logs soon! |
Chroma enabled:
|
Chroma disabled:
|
Maybe this is intentional? Is it expected behaviour that when @snejus did you have that in mind to work like this when you implemented the disabling of MB? |
@ghbrown because you mentioned that you often work with MB disabled, I recenctly do that as well often. Can you reproduce this issue/this behaviour? I often see that tracks that are already tagged with MB, still fetch from MB, especially tracks tagged via chroma+MB. Is it a problem on my end or have you seen it? |
@JOJ0 I do not use I will try it out and see what is going with it. |
@JOJ0 I haven't retagged anything, and I have disabled Musicbrainz from the start, so I don't think I'll have any Musicbrainz stuff in my database. I can reasonably confidently confirm that if one disables Musicbrainz and imports new singletons while matching to Discogs, there is no interference, results, etc. from Musicbrainz. |
Tested a couple of variations of album and singleton import and using musicbrainz:
enabled: no disables the data search only. It allows lookups when album and track ids are already resolved (for example, As far as I remember, this should also allow you to import any musicbrainz ID when you pass it into the This may explain why some singleton imports resolved to musicbrainz - I'd expect it if their metadata contains musicbrainz ids. Similar story with If you run |
Thanks for the explanation @snejus that is exactly the behaviour I'm experiencing. Yes if an mbid is present or if a musicbrainz url/Id is entered, MB is still fetched as usual. I'm not sure if I like this behaviour because:
I would have expected excatly that same behaviour. Do you think that would be possible easily? Or would that break stuff with the "mother of all metadata sources" aka MusicBrainz? ;-))) |
I didn't read through #4319 thoroughly , you might have discussed this behaviour and everything is intentional. will do my homework....later....haha :-) |
I see what you mean - I can definitely imagine a use case where I want to reimport/re-tag some of my music if I start using a new data source. It's possible, but doing it cleanly may require some effort given how deeply the code base is penetrated by musicbrainz :) |
I figured that yeah. I wouldnt be brave enough for now haha. Anyways it's a cool feature so thanks!! |
so people whats the command and where do i find it in the docs? |
You need the dev version (just clone the git repo).
|
@PrinzNika some info on dev install options: https://beets.readthedocs.io/en/latest/faq.html#id8 |
Found my way here from the related issue #400 as I'm also trying to use a metadata source other than MusicBrainz... Just to follow up on this, I noticed from #4319 that the branch was merged in to master in March of 2022, but the latest distributed package is still from November 2021. Are there any plans for an updated release in the near future? I understand it's possible to simply source beets from here on GitHub, only the main website and the 'Getting Started' guide in the docs still suggest using either a distro specific package manager, Willing to contribute any way that I can (e.g. #3350). I'm (still) not great with Python yet but getting better, and I was planning to create a virtual-environment for beets dev just in case anyway! |
Thank you J0J0
I see the 'enabled' config option now.
Now I just need to get around to sourcing beets from github instead of pip
-- I'm not in any immediate rush -- I used the "non-existent local
musicbrainz server" hack as a temporary fix
…On Sun, 7 Apr 2024, 22:49 J0J0 Todos, ***@***.***> wrote:
so people whats the command and where do i find it in the docs?
You need to switch docs to latest version, it defaults to stable:
https://beets.readthedocs.io/en/latest/reference/config.html#id116
—
Reply to this email directly, view it on GitHub
<#4605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANU7HPA4VNRW6PKFWB6A2DY4G5QLAVCNFSM6AAAAAATJS2PK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGYYTSOBTGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
You can still install the github dev version via pip using |
I am using the dev git version (1.6.1), thus i should be able to put
musicbrainz: enabled: no
into my config.yaml.I also added the
plugin: spotify
option to only use spotify (since I know that almost all of my tracks are on spotify, and musicbrainz fails to recognize 1/3 of my music collection)This isn't really working since
beet import -g
orbeet import -s
still uses musicbrainz.Is there a option to only use Spotify Candidates for Albums / singleton files?
I already tried several options like
prefered: media: Spotify
and others.The text was updated successfully, but these errors were encountered: