Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show whether a match option is a duplicate #351

Open
sampsyo opened this issue Jul 29, 2013 · 4 comments
Open

Show whether a match option is a duplicate #351

sampsyo opened this issue Jul 29, 2013 · 4 comments
Assignees
Labels
feature features we would like to implement

Comments

@sampsyo
Copy link
Member

sampsyo commented Jul 29, 2013

In the candidate chooser screen, we should "preview" whether the album already exists in the library (i.e., whether the duplicate checker will be tripped if the album is selected). Suggestion due to @willscott.

@discopatrick
Copy link
Member

@sampsyo - I'm noticing that during the import process, duplicates are not queried by a musicbrainz ID as I had expected, but actually by a query for the album and albumartist, making the concept of a duplicate more "fuzzy" than I had thought it was.

beets/beets/importer.py

Lines 659 to 662 in 9f945a7

duplicate_query = dbcore.AndQuery((
dbcore.MatchQuery('albumartist', artist),
dbcore.MatchQuery('album', album),
))

The feature I was planning to add to beets was to show whether a match option was an exact musicbrainz match.

Is the latter something you'd be happy to have in beets? And if so, should I incorporate it into the same pull request?

@sampsyo
Copy link
Member Author

sampsyo commented Mar 8, 2018

Sounds interesting! Sure, matching my MusicBrainz release ID seems like a reasonable option—would this be a new configuration option?

It would be great if the match-choice screen used the same behavior as the post-facto duplicate detector, whatever that's configured to be.

@discopatrick
Copy link
Member

Great idea - allow the user to choose what the definition of a "duplicate" is in the config.

@8h2a
Copy link
Contributor

8h2a commented Jun 13, 2018

Additionally to choosing the definition of a duplicate it would be nice if we could display more information for those duplicates.
E.g. some users may want to print the path, id, catalognum, tracks, files, ...

Related issues:
Show more info when asking about duplicated album #1131
Importer duplicate detection: configurable field set #1133
In duplicate resolution prompt, list the tracks in the “old” album #2852
Choose which albums to remove/merge when adding duplicates #2809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

3 participants