Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more info when asking about duplicated album #1131

Open
pescuma opened this issue Dec 5, 2014 · 4 comments
Open

Show more info when asking about duplicated album #1131

pescuma opened this issue Dec 5, 2014 · 4 comments
Labels
feature features we would like to implement

Comments

@pescuma
Copy link

pescuma commented Dec 5, 2014

When asking the user to choose what to do with duplicated albums, it would be helpful to show the differences in more fields, if available.


Original text:

When importing albums with same artist and album names, but different years, the importer says that they are the same and shows the list of olds and new:

Old: 12 items, MP3, 192kbps, 35:10
Old: 12 items, MP3, 155kbps, 41:39
Old: 13 items, MP3, 192kbps, 41:04
New: 7 items, MP3, 160kbps, 35:52

I'd like to ask for 2 features here:

  1. Show also the album names, as configured in list_format_album
  2. Do not assume the albums are the same when the year changes
@sampsyo
Copy link
Member

sampsyo commented Dec 5, 2014

Interesting issue!

  • This wouldn't be tremendously useful in the default configuration. But I understand the motivation—maybe we should just show a few of the standard disambiguator fields, like year, media, and catalog number, if they differ among the releases.
  • I'm not sure about weakening the duplicate detection to distinguish albums of different years. If anything, we would do a general configurable list of fields that define duplicates.

This seems like two separate issues. Care to open a new one for one or the other?

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Dec 5, 2014
@pescuma pescuma changed the title Importing album with same artist and album names Show more info when asking about duplicated album Dec 6, 2014
@pescuma
Copy link
Author

pescuma commented Dec 6, 2014

@sampsyo Done

@sampsyo sampsyo added feature features we would like to implement and removed needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." labels Dec 6, 2014
@sampsyo
Copy link
Member

sampsyo commented Dec 6, 2014

Awesome; thanks.

@Vrihub
Copy link
Contributor

Vrihub commented Feb 3, 2017

  1. Show also the album names, as configured in list_format_album

While we wait for #1133 is it possible to have item 1. implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

3 participants