discogs: add 'Featuring' artists to the 'artist' field

[kergoth]

Use case

Currently the Discogs importer throws away info about 'featuring' artists, as this is in the credits / extraartists, not artists, along with other roles like Producer. This is quite different from the behavior of the musicbrainz importer due to how MusicBrainz stores this information. I'd expect the artist to match up when importing the same album from two different importers, other than cosmetic differences due to differing database guidelines.

Solution

For feature/behavior parity with the default MusicBrainz importer, I think we should append these to the artist field, i.e. feat. SomeArtist, AnotherArtist.

[kergoth]

Ex. this track from The Amazon Groove, via the API. Specifically "role": "Featuring" on the entries in extraartists:

        {
            "artists": [
                {
                    "anv": "",
                    "id": 576190,
                    "join": ",",
                    "name": "Matty G",
                    "resource_url": "https://api.discogs.com/artists/576190",
                    "role": "",
                    "tracks": ""
                },
                {
                    "anv": "DJ Rupture",
                    "id": 63742,
                    "join": ",",
                    "name": "DJ /rupture",
                    "resource_url": "https://api.discogs.com/artists/63742",
                    "role": "",
                    "tracks": ""
                },
                {
                    "anv": "",
                    "id": 26561,
                    "resource_url": "https://api.discogs.com/artists/576190",
                    "role": "",
                    "tracks": ""
                },
                {
                    "anv": "DJ Rupture",
                    "id": 63742,
                    "join": ",",
                    "name": "DJ /rupture",
                    "resource_url": "https://api.discogs.com/artists/63742",
                    "role": "",
                    "tracks": ""
                },
                {
                    "anv": "",
                    "id": 26561,
                    "join": "",
                    "name": "Lloop",
                    "resource_url": "https://api.discogs.com/artists/26561",
                    "role": "",
                    "tracks": ""
                }
            ],
            "duration": "3:39",
            "extraartists": [
                {
                    "anv": "",
                    "id": 1685603,
                    "join": "",
                    "name": "Autumn Rain",
                    "resource_url": "https://api.discogs.com/artists/1685603",
                    "role": "Featuring",
                    "tracks": ""
                },
                {
                    "anv": "",
                    "id": 103499,
                    "join": "",
                    "name": "Elizabeth Alexander",
                    "resource_url": "https://api.discogs.com/artists/103499",
                    "role": "Featuring",
                    "tracks": ""
                }
            ],
            "position": "22",
            "title": "Layin In Bed",
            "type_": "track"
        }

For comparison, we can examine the MusicBrainz Release, but their info on this album is even worse, including the featuring artists in the track titles ((feat. Elizabeth Alexander and Autumn Rain)) when it should be in artist, and including the record label in the title. Presumably this is how they were listed on the album, but it doesn't align with MusicBrainz guidelines afaict.

[kergoth]

master...kergoth:prototype-discogs-featuring is an ugly first prototype of the sort of thing I'm looking for.

[sampsyo]

Sounds good! Something like this seems like the right thing to do.

[kergoth]

Thanks for the quick feedback. I'll see about cleaning up what I have and submitting a pull req.

[sanpoChew]

@kergoth just curious on the status of this fix? find this very annoying personally

[JOJ0]

This feature was implemented in #4515

FYI @sanpoChew @kergoth