Merge pull request #3030 from projectgus/remove_missing_albumart

move_art: Remove missing album art
beetbox · Oct 9, 2018 · b0add60 · b0add60
2 parents a7e44e8 + e58ddbf
commit b0add60
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/beets/library.py b/beets/library.py
@@ -1030,6 +1030,12 @@ def move_art(self, operation=MoveOperation.MOVE):
         if not old_art:
             return
 
+        if not os.path.exists(old_art):
+            log.error(u'removing reference to missing album art file {}',
+                      util.displayable_path(old_art))
+            self.artpath = None
+            return
+
         new_art = self.art_destination(old_art)
         if new_art == old_art:
             return

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -95,6 +95,9 @@ Fixes:
 * The ``%aunique`` template function now works correctly with the
   ``-f/--format`` option.
   :bug:`3043`
+* Missing album art file during an update no longer causes a fatal exception
+  (instead, an error is logged and the missing file path is removed from the
+  library). :bug:`3030`
 
 .. _python-itunes: https://github.com/ocelma/python-itunes