Switch to using check_call for hooks

beetbox · Oct 17, 2019 · 648f230 · 648f230
1 parent 4d55e6d
commit 648f230
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/beetsplug/hook.py b/beetsplug/hook.py
@@ -105,7 +105,9 @@ def hook_function(**kwargs):
                             u' '.join(command_pieces), event)
 
             try:
-                subprocess.Popen(command_pieces).wait()
+                subprocess.check_call(command_pieces)
+            except subprocess.CalledProcessError as exc:
+                self._log.error(u'hook for {0} exited with status {1}', event, exc.returncode)
             except OSError as exc:
                 self._log.error(u'hook for {0} failed: {1}', event, exc)