Made images a global collection #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed endpoints for images - Removed example (other resources don't have examples) - Added relationship requirements - Added reason for /aura/images to be a 404 - Made suggestion to use compound ids - Moved Images section to after Artists (so collections are together) See #3 for relevant discussion.
|
How does this look? |
sampsyo
approved these changes
Aug 13, 2020
| In contrast to the other resource types, servers **SHOULD** respond with an | ||
| HTTP 404 error for the URL ``/aura/images``. This is because enumerating all | ||
| images may be difficult for the server, and a large collection of image | ||
| metadata is not generally useful to music browsers and players. |
There was a problem hiding this comment.
An interesting point I might not have thought of, but I like it!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3 for relevant discussion.