Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if there is no gpg key for a given email #243

Closed
extsoft opened this issue Jan 15, 2020 · 1 comment
Closed

Don't fail if there is no gpg key for a given email #243

extsoft opened this issue Jan 15, 2020 · 1 comment
Labels
bug finalize requirements

Comments

@extsoft
Copy link
Contributor

extsoft commented Jan 15, 2020

The bug

Elegant Git raises non-zero exit code if there is no gpg key for an email.

Steps to reproduce

~/tmp git clone-repository [email protected]:some-repo.git
==>> git clone clone-repository [email protected]:some-repo.git
Cloning into 'some-repo'...
.......
===========================
== Configuring basics... ==
===========================
Please hit enter if you wish {default value}.
......
==============================
== Configuring signature... ==
==============================
==>> gpg --list-secret-keys --keyid-format long [email protected]
gpg: error reading key: No secret key
~/tmp echo $?
2

Expected behavior

The program exits with 0 exit code.

My environment

  • git --version: 2.24.0
  • bash --version: 3.2.57
  • OS: MacOS
extsoft added a commit that referenced this issue Feb 9, 2020
@extsoft
Abort signature configuration if there is no key
9d453ce 
Sometimes happens that there is no GPG key for the given email. In this
case, the configuration will be successfully completed.

#243
@extsoft
Copy link
Contributor Author

extsoft commented Feb 9, 2020

Solved in version 0.17.0.

@extsoft extsoft closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug finalize requirements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@extsoft