Add initial support for importing Google Authenticator export QR codes #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaelschattgen
left a comment
michaelschattgen
left a comment
There was a problem hiding this comment.
That was quick, nice work! Minor nitpicks before we can merge this.
app/src/main/java/com/beemdevelopment/aegis/otp/GoogleAuthInfo.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/ScannerActivity.java
Outdated
Show resolved
Hide resolved
alexbakker
force-pushed
the
import-google-qr-export
branch
from
7984331 to
66f17d4
Compare
alexbakker
force-pushed
the
import-google-qr-export
branch
from
66f17d4 to
56bde0e
Compare
Member
Author
|
Addressed the comments. |
ghost
mentioned this pull request
andreanadr
approved these changes
Feb 24, 2024
zaidusmanali
approved these changes
Aug 21, 2024
andreanadr
approved these changes
Aug 31, 2024
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for importing the new Google Authenticator QR codes shown when exporting. I'm not 100% sure if I got all of the types in the protobuf message definitions correct, but it seems to work well.