Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4524] Optimize maligned structs #4525

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

nitinmohan
Copy link

Proposal: #4524

All offending structs have been optimized. Some fields, although not required, have been moved around a bit to be more logical in their layout.

@nitinmohan nitinmohan force-pushed the feature/optimize-maligned-structs branch from 24745e5 to f554a1c Compare March 8, 2021 07:32
@jianzhiyao jianzhiyao requested review from flycash and jianzhiyao and removed request for flycash March 8, 2021 08:26
Copy link
Member

@jianzhiyao jianzhiyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

>golangci-lint run ./... --disable-all -E maligned --timeout=1h
>[no output]

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flycash flycash merged commit b1c9f66 into beego:develop Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants