[BUGFIX] Avoid PHP warning for request of eID=FalSecuredownloadFileTreeState #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nloadFileTreeState Avoid "PHP Warning: Undefined array key "folder" in Classes/Controller/FileTreeStateController.php" (and subsequent creation of sys_log record) when requesting /index.php?eID=FalSecuredownloadFileTreeState without a "folder" parameter by defining a default value. As the same issue might arise for a call to an existing folder requesting without an "open" parameter define a default here too. These calls usually are triggered by bots calling all URLs found in the site Javascript.
|
As this is the only issue found so far for the production use, would it be possible to tag a new version 5.0.0 when this has been merged? Thanks! |
|
@sgrossberndt Release made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid "PHP Warning: Undefined array key "folder" in Classes/Controller/FileTreeStateController.php" (and subsequent creation of sys_log record) when requesting /index.php?eID=FalSecuredownloadFileTreeState without a "folder" parameter by defining a default value.
As the same issue might arise for a call to an existing folder requesting without an "open" parameter define a default here too.
These calls usually are triggered by bots calling all URLs found in the site Javascript.