[TASK] Resolve isRelativeToCurrentScript deprecation #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeneratePublicUrlForResourceEvent::isRelativeToCurrentScript is deprecated since TYPO3 11.3.0. There parameter is also not used in PublicUrlAspect::generatePublicUrl, so we just set it to "false" for now in order to resolve deprecation notices in TYPO3 log. The signature of PublicUrlAspect::generatePublicUrl should be adjusted next breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeneratePublicUrlForResourceEvent::isRelativeToCurrentScriptis deprecated since TYPO3 11.3.0.There parameter is also not used in
PublicUrlAspect::generatePublicUrl, so we just set it to "false" for nowin order to resolve deprecation notices in TYPO3 log.
The signature of
PublicUrlAspect::generatePublicUrlshould be adjusted next breaking change.