Merge pull request #218 from sdelcroix/fix-217

[BUGFIX] Fix Exception: in Hooks\AbstractBeButtons::generateButtons() if _GP('id') is null

Classes/Hooks/DocHeaderButtonsHook.php

@@ -27,6 +27,7 @@
 
 namespace BeechIt\FalSecuredownload\Hooks;
 
+use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\UriInterface;
 use TYPO3\CMS\Backend\Routing\Exception\RouteNotFoundException;
 use TYPO3\CMS\Backend\Template\Components\ButtonBar;
@@ -62,7 +63,10 @@ public function getButtons(array $params, ButtonBar $buttonBar): array
     {
         $buttons = $params['buttons'];
 
-        foreach ($this->generateButtons(GeneralUtility::_GP('id')) as $buttonInfo) {
+        $identifier = $this->getRequest()->getQueryParams()['id'] ?? null;
+        if(is_null($identifier)) return $buttons;
+
+        foreach ($this->generateButtons($identifier) as $buttonInfo) {
             $button = $buttonBar->makeLinkButton();
             $button->setIcon($buttonInfo['icon']);
             $button->setTitle($buttonInfo['title']);
@@ -72,4 +76,12 @@ public function getButtons(array $params, ButtonBar $buttonBar): array
 
         return $buttons;
     }
+
+    /**
+     * Get Request
+     */
+    private function getRequest(): ServerRequestInterface
+    {
+        return $GLOBALS['TYPO3_REQUEST'];
+    }
 }