Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added loads of test candidates and updated discord webhook regex #216

Merged
merged 4 commits into from
Oct 22, 2021

Conversation

IlluminatiFish
Copy link
Contributor

Prerequisites

Why do we need this pull request?

Better webhook url regex, to allow other subdomains such as ptb & canary which are actively used as well as allowing for the detection of webhooks using the old domain discordapp.com and allowing for the matching of webhook urls that include the api version after the api path and more distinct expressions for webhook tokens and webhook ids, also allowing for webhook urls that have the scheme of http

What GitHub issues does this fix?

Expands upon changes made in #173 and continuation of #208 due to merge conflicts with new regex test system introduced via #202

Copy / paste of output

Couldn't get the script to work so I could not test the changes to the regex i've made with the regex however I have tested it on its own in python 3.10 as well as using https://pythex.org

Added loads of test candidates and updated discord webhook regex as per bee-san#208
@bee-san
Copy link
Owner

bee-san commented Oct 19, 2021

your tests fail :(

@IlluminatiFish
Copy link
Contributor Author

your tests fail :(

yeah..that's odd

lmao json formatting goes brr
@IlluminatiFish
Copy link
Contributor Author

your tests fail :(

lmao im dumb 😆 , forgot to remove the extra , in the valid json array

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #216 (c441226) into main (75e38c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          14       14           
  Lines        1204     1204           
=======================================
  Hits         1114     1114           
  Misses         90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e38c6...c441226. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants