-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake8 #195
flake8 #195
Conversation
Co-authored-by: piatrashkakanstantinass <[email protected]>
One last error left:
@piatrashkakanstantinass you added this code, do you know what exception is being excepted? I'm pretty sure it's def __contains__(self, item):
try:
return (
self["MinRarity"] <= item["Rarity"] <= self["MaxRarity"]
and set(item["Tags"]) & self["Tags"]
and not set(item["Tags"]) & self["ExcludeTags"]
)
except:
return False |
I do not know😅. I checked it now and did not find any place for exceptions. |
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 92.37% 92.52% +0.14%
==========================================
Files 14 14
Lines 1207 1204 -3
==========================================
- Hits 1115 1114 -1
+ Misses 92 90 -2
Continue to review full report at Codecov.
|
@@ -222,7 +222,7 @@ def main(**kwargs): | |||
|
|||
%t - tags (in 'tag1, tag2 ...' format) | |||
|
|||
If you want to print '%' or '\' character - escape it: '\%', '\\'. | |||
If you want to print '%' or '\\' character - escape it: '\\%', '\\\\'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now shown correctly when printed.
Before:
If you want to print '%' or '' character - escape it: '\%', '\'.
After:
If you want to print '%' or '\' character - escape it: '\%', '\\'.
⚠ Pull Requests not made with this template will be automatically closed 🔥
Prerequisites
Why do we need this pull request?
flake8 enforces style consistency across Python projects.
The
--select
option in flake8 disables all other linting errors. Removing this option shows some areas of the code that could use some improvement.A better way to ignore errors is to put them in a configuration file so that running
flake8
on a local machine also ignores the same errors.What GitHub issues does this fix?
None
Copy / paste of output
Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below: