Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: enable host aliases in common chart #130

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[common]: enable host aliases in common chart #130

merged 3 commits into from
Apr 18, 2024

Conversation

wthhub
Copy link
Contributor

@wthhub wthhub commented Apr 12, 2024 •
edited
Loading

What this PR does:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@wthhub wthhub self-assigned this Apr 12, 2024
@wthhub wthhub requested a review from a team as a code owner April 12, 2024 07:51
@wthhub wthhub requested a review from larsgerber April 12, 2024 07:51
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@wthhub wthhub force-pushed the feat/enable-setting-hostaliases-in-common branch from 1825946 to 3ed659a Compare April 12, 2024 07:56
@adberger
Copy link
Contributor

Please pay attention to the Checklist in this PR.
Also in my opinion this is a feature bump and not a bugfix bump of the helm chart.

@wthhub wthhub force-pushed the feat/enable-setting-hostaliases-in-common branch from c896cc2 to 89a11c6 Compare April 12, 2024 09:21
@wthhub wthhub changed the title [feat]: enable host aliases in common chart [common]: enable host aliases in common chart Apr 18, 2024
@adberger
Copy link
Contributor

In the values.yaml file there should be examples commented out underneath hostAliases in order for users to get an understanding what to set and what not.

Except that, the PR looks fine

@wthhub wthhub force-pushed the feat/enable-setting-hostaliases-in-common branch from 9d14400 to 0bacd0b Compare April 18, 2024 09:35
adberger
adberger approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@adberger adberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wthhub wthhub merged commit 8342aa7 into master Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adberger adberger adberger approved these changes

@larsgerber larsgerber Awaiting requested review from larsgerber larsgerber is a code owner automatically assigned from bedag/sre

Assignees

@wthhub wthhub

Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wthhub @adberger