fix(installer): properly check cuda driver & gpu plugin #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eball
approved these changes
Jan 7, 2025
eball
pushed a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GPU-related pods will not be created if the system has not enabled GPU, thus their Running status need not to be checked
handle the case where
nvidia-smitool is installed but CUDA is notrestart GPU plugins properly
Target Version for Merge
v1.11.1 v1.12.0
Related Issues
none
PRs Involving Sub-Systems
fix: check gpu status prepare Installer#95
fix: handle the case where nvidia-smi is installed but no cuda driver Installer#96
Other information:
none