Drop old phpunit and symfony versions #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No.
Yes. PHPUnit 8.5 supports PHP 7.2 which is the lowest PHP version we currently support, so PHPUnit 7 can be dropped.
👍🏻 |
derrabus
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, orm2 tests will run with
dependency-versions: "lowest"setting and orm3 tests will run withhighestsetting. Due to the restriction of orm3 php>=8.1, orm2 tests must also run on php8.0. The phpunit 7 does not support php8, so we should drop phpunit7.And I dropped symfony 4 because that branch is no longer officially supported.
What do you think?