-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Python packaging #831
Conversation
* distutils no longer works correctly * fixed testing: use the py.test framework
To be honest, I don't know enough about this to know if it is correct or not. Could you provide some pointers to documentation I can read to understand this domain? |
Hello Liam,
setuptools vs. distutils:
Debian packaging: the patch includes a minimal set of packaging files to -- Matthias Urlichs |
Yes, other than it works. :) Okay, I'm getting a sense for the change now. Do we need to update https://github.com/beautify-web/js-beautify/blob/master/CONTRIBUTING.md#publishing-a-release to include how to publish the Debian package? You've updated this to install the python version of the tool, but the javascript/nodejs version is arguably better and includes the html beautifier. Or should the Debian package install both? Can it? |
On 14.12.2015 23:33, Liam Newman wrote:
Updating the Debian package's version would be a nice touch (it's in the
I'm not at all familiar with how to package Node for Debian, though, and -- Matthias Urlichs |
Could you add instructions to https://github.com/beautify-web/js-beautify/blob/master/CONTRIBUTING.md#publishing-a-release on how someone would update this? Whatever you think is reasonable. Including the note that Debian packages may lag behind regular release. Then I'll go ahead and merge. Thanks for your patience and contribution. |
@smurfix - I guess I'll just to take it as a given that you'll maintain the debian packages. |
The first patch adds Debian packaging support.
The second patch fixes setup.py by using setuptools instead of distutils, and adding in py.test so that "setup.py test" works with Python 3.4+.