Webpack

[bitwiseman]

@evocateur @einars @HookyQR @olsonpm @mmsqe

Hello all. This is an early preview of my plan to begin moving to a module based structure for this project. I've like to hear any feedback you have, but there's no hurry, there's still quite a way to go before it lands. If nothing else, I need to mirror the modularization in the Python implementation.

There are two conflicting requirements for this change:

1. Add the ability to reuse modules
2. Make this a completely non-breaking change for end users.

I think I've achieved that. I could use any help you can provide

When this goes in, I will let it bake and make further non-breaking internal changes and clean up.
As part of this change I change the css beautifier to use the same Output class as the js beautifier.

I think this and various follow up refactorings will unblock a number of improvements, such as parsing of html and css, fewer bugs, and eventually a 2.0 release the drops a bunch of legacy hacks.

[evocateur]

Nice!

[evocateur]

Why is this incantation necessary? I thought Travis already used nvm?

[bitwiseman]

@evocateur - only on node projects. This is python project that happens to run node. Travis would default to node 0.12. This was fine until this change - webpack requires a newer version of node to work. Thus incantation.

[evocateur]

Oh yeah, I forgot about that.

[olsonpm]

My two cents

• The begin/end templates used for the lib output is pretty strange. I then started looking for that same functionality in webpack and quickly gave up as I always do when searching for anything with webpack haha. I did find the banner plugin which looked like it would suffice for begin, and end should be taken care of by the umd output as your comment mentions.

• Out of curiosity, why did you extract inputscanner and token into their own modules? They are only required by the javascript beautifier, which makes me wonder how you decided what should be extracted as modules.

everything else looks pretty straight forward - and the modularization will definitely provide real value.

I'm sorry to say I can't spend any time testing as I'm knee deep in a couple side projects and haven't used any beautifiers in some time (my employer's CI process is laughable so I've just gotten used to 'Laissez-faire' looking code).

Edit: As always, I respect the time you put into this library @bitwiseman. You do a solid job.

[bitwiseman]

@olsonpm

• Begin/end Template: I want to have this be functionally equivalent from an api perspective. As you ran into, I couldn't do that using the autogenerated wrapper from webpack. In the long run, I'll remove the templating. It's a hack but it is a hack that is controlled by the project
• Extracting classes - I plan to use the the classes in common for all three beautifiers. Figured I'd extract more classes now to unblock that work, in case anyone has the inclination to start.

Thanks for taking a look. I appreciate the time you've spent on the project and your continued participation.

[bitwiseman]

@evocateur @olsonpm
Thanks for taking a look and asking questions. I appreciate the time you've spent on the project and your continued participation.

[HookyQR]

@bitwiseman Sorry I haven't provided any input. Been pretty busy. May get to have a look this week. 🤞