Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML after PHP is indented #826

Closed
Hirse opened this issue Dec 9, 2015 · 2 comments
Closed

HTML after PHP is indented #826

Hirse opened this issue Dec 9, 2015 · 2 comments
Labels
language: html language: templating type: bug
Milestone
v1.6.0

Comments

@Hirse
Copy link
Contributor

Hirse commented Dec 9, 2015

Any PHP block causes all following tags to be indented by one level.

This came up as brackets-beautify/brackets-beautify#178 in Brackets Beautify, and has also been mentioned here #714 (comment).

Input:

<?php ?>
<!DOCTYPE html>
<html>
<head></head>

<body></body>
</html>

Output:

<?php ?>
    <!DOCTYPE html>
    <html>

    <head></head>

    <body></body>

    </html>

Desired Output:

<?php ?>
<!DOCTYPE html>
<html>

    <head></head>

    <body></body>

</html>
@Hirse Hirse mentioned this issue Dec 9, 2015
Closed
@bitwiseman bitwiseman added this to the v1.6.0 milestone Jan 15, 2016
@bitwiseman bitwiseman mentioned this issue Jan 15, 2016
Closed
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 21, 2016
@bitwiseman
Treat php tags as single in html
6fefba6 
Fixes beautifier#826
Closes beautifier#744
@bitwiseman bitwiseman mentioned this issue Jan 21, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Mar 5, 2017
Merged
@cyberbeat
Copy link

cyberbeat commented May 25, 2018 •
edited
Loading

It would be nice, if this would also work for php "short-open-tags", for example
<? include("include.php"); ?>

@Hirse
Copy link
Contributor Author

Hirse commented May 25, 2018

@bitwiseman would it be as easy as just adding ? and ?= to the list of single_tokens to support php short tags (<? ?>) and short echo tags (<?= ?>)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: html language: templating type: bug
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@cyberbeat @bitwiseman @Hirse