Issue with prometheus client @v0.9.1 when running test

[lvrach]

Issue

I get the following error when running the tests of a specific package:

go test ./async   
# github.com/prometheus/client_golang/prometheus
../../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/collector.go:62:17: undefined: Metric
../../go/pkg/mod/github.com/prometheus/[email protected]/prometheus/collector.go:102:7: undefined: Metric
FAIL    github.com/thebeatapp/patron/async [build failed]

However when I run:
go test ./... It succeeds, but first updates my go.mod file :

github.com/prometheus/client_golang v0.9.1 h1:K47Rk0v/fkEfwfQet2KWhscE0cJzjgCCDBG2KHZoVno=
github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=
+github.com/prometheus/client_golang v0.9.2 h1:awm861/B8OKDd2I/6o1dy3ra4BamzKhYOiGItCeZ740=
+github.com/prometheus/client_golang v0.9.2/go.mod h1:OsXs2jCmiKlQ1lTBmv21f2mNfw4xf/QclQDMrYNZzcM=

It a bit wired behavior, If I had to guess is something related with this one:
prometheus/client_golang#501

After adding the v0.9.2, everything works fine

Solution

I would suggest upgrading the client_golang to v0.9.2

[mantzas]

I have ran the same tests on master but could not confirm the problem.
It seems rather unusual that from 0.9.1 to 0.9.2 something like the Metric was undefined.
@lvrach pls provide the exact way to reproduce the problem.
@cosmix @k0st1s could you pls confirm the problem too?

[mantzas]

this is not reproducable