*: support Go modules #501
Conversation
| ErrExec ErrorType = "execution" | ||
| ErrBadResponse ErrorType = "bad_response" | ||
| ErrServer ErrorType = "server_error" | ||
| ErrClient ErrorType = "client_error" |
There was a problem hiding this comment.
Where is this change coming from? Is it needed/intended?
There was a problem hiding this comment.
It was spotted by the newer version of staticcheck that is compatible with Go modules:
api/prometheus/v1/api.go:58:2: only the first constant in this group has an explicit type (SA9004)
There was a problem hiding this comment.
It is definitely needed. A common misbelief is that type declaration behaves similar to iota. These types were declared without an explicit type and mostly just worked due to Go's automatic type inference.
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973 | ||
| github.com/gogo/protobuf v1.1.1 |
There was a problem hiding this comment.
Inclusion of this happens via prometheus/wrap_test.go, but it's an accident from my side.
I'll send you a PR to fix, and then this should be updated to not include this line.
Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
go-modules
branch
from
44f3721
to
f626bd2
Compare
|
@beorn7 I've rebased on top of master and |
|
Yay. |
No description provided.