Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Embed Toggles for the Join/Leave/Switch Messages #221

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented Aug 31, 2024

Pull Request


Description

There are now new, optional, embed toggles for the Join/Leave/Switch messages.

Fixes #216


Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update
  • Security Vulnerability

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration

  • Hardware:
    • CPU: AMD Ryzen 7 5800x3D
    • GPU: Nvidia RTX 3080
    • RAM: 32 GB DDR4
  • JDK: Java OpenJDK 17

Checklist

  • This pull request has been linked to the appropriate issue on GitHub. (Use the development section on the right.)
  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Gradle CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft SimpleProxyChat Releases update.

@beanbeanjuice beanbeanjuice added small Something small that needs to be added. improvement Improving an existing part of code. labels Aug 31, 2024
@beanbeanjuice beanbeanjuice self-assigned this Aug 31, 2024
Copy link
Owner Author

@beanbeanjuice beanbeanjuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@beanbeanjuice beanbeanjuice linked an issue Aug 31, 2024 that may be closed by this pull request
2 tasks
@beanbeanjuice beanbeanjuice merged commit 6725017 into development Aug 31, 2024
3 checks passed
@beanbeanjuice beanbeanjuice deleted the 216-join-leave-switch-embed branch August 31, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improving an existing part of code. small Something small that needs to be added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Webhook mode for messages to Discord
1 participant