Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Discord Nickname Prefix #161

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented May 28, 2024

Pull Request


Description

You can now differentiate between %user% and %nick% on the Discord to Minecraft chat.

Fixes #160


Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update
  • Security Vulnerability

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration

  • Hardware:
    • CPU: AMD Ryzen 7 5800x3D
    • GPU: Nvidia RTX 3080
    • RAM: 32 GB DDR4
  • JDK: Java OpenJDK 17

Checklist

  • This pull request has been linked to the appropriate issue on GitHub. (Use the development section on the right.)
  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Maven CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft ProxyChat Releases update.

@beanbeanjuice beanbeanjuice added feature New feature or request small Something small that needs to be added. labels May 28, 2024
@beanbeanjuice beanbeanjuice self-assigned this May 28, 2024
@beanbeanjuice beanbeanjuice linked an issue May 28, 2024 that may be closed by this pull request
2 tasks
Copy link
Owner Author

@beanbeanjuice beanbeanjuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@beanbeanjuice beanbeanjuice merged commit 2e86799 into development May 28, 2024
3 checks passed
@beanbeanjuice beanbeanjuice deleted the 160-discord-nicknames branch May 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request small Something small that needs to be added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Separate Discord Username & Nickname Placeholders
1 participant