Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So that we can use list sequences, fixes #223 #227

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

suhrawardi
Copy link
Contributor

Now we can use list sequences, as proposed in #223

  def user_factory do
    %MyApp.User{
      name: "Jane Smith",
      email: sequence(:email, &"email-#{&1}@example.com"),
      role: sequence(:role, ["admin", "user", "other"]),
    }
  end

@suhrawardi suhrawardi mentioned this pull request Jun 28, 2017
Copy link
Contributor

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! Could you add some docs to https://github.com/thoughtbot/ex_machina/blob/master/lib/ex_machina.ex#L127 as well? I think it's more likely that people will look there.

@suhrawardi
Copy link
Contributor Author

@paulcsmith, sure, added it!
Must have overlooked that one... :-)

@germsvel germsvel merged commit 779b4c8 into beam-community:master Oct 20, 2017
@germsvel
Copy link
Collaborator

Thanks for this PR @suhrawardi!

@smt116 smt116 mentioned this pull request Nov 17, 2017
germsvel added a commit that referenced this pull request Mar 13, 2018
Bump version to 2.2.0. Notable changes include,

- Support for lists in sequences (PR #227)
- Using `Macro.underscore/1` so that factory names don't break in elixir
1.6 (PR #275)
@germsvel germsvel mentioned this pull request Mar 13, 2018
germsvel added a commit that referenced this pull request Mar 13, 2018
Bump version to 2.2.0. Notable changes include,

- Support for lists in sequences (PR #227)
- Using `Macro.underscore/1` so that factory names don't break in elixir
1.6 (PR #275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants