Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fields_for to params_for #96

Closed
paulcsmith opened this issue Feb 8, 2016 · 2 comments
Closed

Change fields_for to params_for #96

paulcsmith opened this issue Feb 8, 2016 · 2 comments
Assignees

Comments

@paulcsmith
Copy link
Contributor

I often use fields_for when creating or updating records in API endpoints or for testing controllers. I think params_for makes more sense in these cases.

post comment_path(conn, :create), params_for(:comment)

paulcsmith added a commit that referenced this issue Feb 26, 2016
paulcsmith added a commit that referenced this issue Feb 26, 2016
@paulcsmith paulcsmith changed the title Consider changing fields_for to params_for Change fields_for to params_for Feb 26, 2016
@paulcsmith paulcsmith self-assigned this Feb 26, 2016
@BlakeWilliams
Copy link

I personally like fields_for because of what the function does but I don't feel strongly about it. LGTM

paulcsmith added a commit that referenced this issue Mar 4, 2016
@paulcsmith
Copy link
Contributor Author

Closed by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants