Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for Julia 1.11 #172

Merged
merged 12 commits into from
Oct 9, 2024
Merged

fixes for Julia 1.11 #172

merged 12 commits into from
Oct 9, 2024

Conversation

palday
Copy link
Member

@palday palday commented Oct 8, 2024

@palday palday changed the title ignore versioned manifest fixes for Julia 1.11 Oct 8, 2024
.gitignore Show resolved Hide resolved
test/samples.jl Outdated Show resolved Hide resolved
@palday palday marked this pull request as ready for review October 9, 2024 16:06
@palday palday requested review from omus and jrevels October 9, 2024 16:07
@omus
Copy link
Member

omus commented Oct 9, 2024

  • update tests to use static values instead of depending on MersenneTwister, which can (and does) change outputs between Julia versions

Any reason you decided not to use StableRNGs.jl?

@palday
Copy link
Member Author

palday commented Oct 9, 2024

  • update tests to use static values instead of depending on MersenneTwister, which can (and does) change outputs between Julia versions

Any reason you decided not to use StableRNGs.jl?

Because it was a single short example and it was easier to just use the values that MersenneTwister formerly produced rather than update the test results. This also made it so that the reference values didn't change, which makes it easier to check that I didn't break something else with the changes here.

src/serialization.jl Outdated Show resolved Hide resolved
@palday palday merged commit a24a92a into main Oct 9, 2024
6 checks passed
@palday palday deleted the pa/manifest branch October 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants