-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for Julia 1.11 #172
Merged
Merged
fixes for Julia 1.11 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Oct 8, 2024
iamed2
reviewed
Oct 9, 2024
Co-authored-by: Eric Davies <[email protected]>
Any reason you decided not to use StableRNGs.jl? |
Because it was a single short example and it was easier to just use the values that MersenneTwister formerly produced rather than update the test results. This also made it so that the reference values didn't change, which makes it easier to check that I didn't break something else with the changes here. |
ararslan
reviewed
Oct 9, 2024
iamed2
approved these changes
Oct 9, 2024
ararslan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use public API for accessing the contents of an IOBufferSkip needing that IOBuffer entirelyMersenneTwister
, which can (and does) change outputs between Julia versionsread(io, typemax(Int))
when reading from aProcess
on 1.11 (this caused the FLAC tests to fail). (xrefreadbytes!(::Process, ::Vector{UInt8}, ::Int)
does not read bytes on 1.11 JuliaLang/julia#56078)