Merged
Conversation
This was referenced Nov 1, 2023
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 1, 2023
Sprinkle cstdint everywhere that it's used. Unblocks the next impeller-cmake bump. Ran into include issues during the build for the most recent impeller-cmake bump: bdero/impeller-cmake#20 Going to add an optional libcxx STL build to help avoid stuff like this later (in the AAOS action items).
Fixes breakages from: * flutter/engine#47080 * flutter/engine#47247 * flutter/engine#47278
bdero
added a commit
to flutter/engine
that referenced
this pull request
Nov 1, 2023
bdero/impeller-cmake#20 Fixes breakages from: * #47080 * #47247 * #47278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes breakages from: