Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsobj #246

Closed
wants to merge 63 commits into from
Closed

Obsobj #246

wants to merge 63 commits into from

Conversation

bd-j
Copy link
Owner

@bd-j bd-j commented Jun 19, 2022 •
edited
Loading

Work to do includes

  • Convert to/from old style observation dictionaries
  • Put responsibility for Noise Models including outliers in individual Observation instances
  • Make predictions even when there is no fittable data (e.g. model spectra when fitting photometry only)
  • Store Observation objects in HDF5, FITS, etc as structured arrays with metadata
  • Test multi-spectra calibration
  • Test multi-spectral smoothing
  • Test multi-spectra noise modeling
  • Update demo scripts
  • Update docs
  • Update notebooks
  • Handle emission line marginalization if spectra overlap
  • Structured ndarray for output chains and lnlikehoods

@bd-j bd-j force-pushed the obsobj branch 2 times, most recently from b800215 to d49020b Compare June 19, 2022 14:21
@bd-j
Copy link
Owner Author

bd-j commented Jun 19, 2022

ok, main thing now is to do some testing of the multi-spec capabilities, then this should be ready to merge into v2.0

@bd-j bd-j mentioned this pull request Jun 27, 2022
Closed
@bd-j
Copy link
Owner Author

bd-j commented Nov 21, 2022

It would be good to add another Observation subclass for integrated emission lines.

bd-j added 21 commits January 2, 2023 16:46
@bd-j
start work on Observation class.
b2a4a91
@bd-j
messing about.
4f3994b
@bd-j
updates to the Observation class for backwards compatibility.
ad7871a
@bd-j
working basic predictions with multiple spectra.
99f080e
@bd-j
move noise models to observation objects; modify likelihoods to deal …
d2d7806 
…with lists of observations.
@bd-j
offload likelihood computation to noise model objects.
94fc346
@bd-j
fitting ubdates for observation lists; dosctring modernization.
eae615e
@bd-j
bugfixes for filters.
1fc824c
@bd-j
fix typos, more testing.
773f359
@bd-j
remove SedModel and it's subclasses; cache library resolution if avai…
d72c7c1 
…alble.
@bd-j
move observation submodule to new data module; numerous tweaks to obs…
e918881 
…ervation generation from old style dicts; changes to test_eline for new predict() api.
@bd-j
duh init.
ac47c62
@bd-j
fix up new predictions test.
1343b94
@bd-j
update docs for new observation object.
bee8f19
@bd-j
duh
4ac115b
@bd-j
docs, including noise model description.
02b2bd2
@bd-j
remove utils.smoothing, switch to using astro-sedpy for smoothing.
082a719
@bd-j
updating demos for new Observation class.
bf47109
@bd-j
more demo and doc updates.
2b430d6
@bd-j
Observatio object methods to convert to structures, fits, h5, etc.
0f5e448
@bd-j
Observation docstrings; new Observation.Lines class; fix import error…
99a6388 
… in sedmodel.
@bd-j bd-j mentioned this pull request Jan 3, 2024
Merged
3 tasks
@bd-j bd-j closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bd-j