`run-s` crashes when upgrading to v8

[viceice]

See below. node crashed with code 137 when running my prepare script run-s -s 'prepare:**' 🤔

12:34:53  + pnpm install
12:34:53  Lockfile is up to date, resolution step is skipped
12:34:53  Progress: resolved 1, reused 0, downloaded 0, added 0
12:34:53  Packages: +157
12:34:53  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
12:34:54  Progress: resolved 157, reused 0, downloaded 156, added 156
12:34:55  Progress: resolved 157, reused 0, downloaded 157, added 157, done
12:34:55  
12:34:55  devDependencies:
12:34:55  + @prettier/plugin-xml 3.4.1
12:34:55  + @types/node 20.17.48
12:34:55  + @types/shelljs 0.8.16
12:34:55  + @visualon/gitea-releaser 1.1.1
12:34:55  + del 8.0.0
12:34:55  + husky 9.1.7
12:34:55  + lint-staged 16.0.0
12:34:55  + npm-run-all2 8.0.2
12:34:55  + prettier 3.5.3
12:34:55  + prettier-plugin-packagejson 2.5.14
12:34:55  + shelljs 0.10.0
12:34:55  + typescript 5.8.3
12:34:55  
12:34:55  
12:34:55  > @xxx/yyy@4.0.0 prepare /var/jenkins/workspace/xxx_renovate_npm-run-all2-8-x
12:34:55  > run-s -s 'prepare:**'
12:34:55  
12:37:25  Cannot contact docker-d07: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@70fc0e6a:xxx-d07": Remote call on docker-d07 failed. The channel is closing down or has closed down
12:38:20  /usr/local/bin/node: line 19:    52 Killed                  /opt/containerbase/tools/node/22.15.1/bin/node "$@"
script returned exit code 137

[viceice]

I also saw this error sometimes:

/var/jenkins/workspace/xxx_main/node_modules/.bin/run-s: 20: exec: node: Argument list too long
ELIFECYCLE  Command failed with exit code 1.
script returned exit code 1

[viceice]

on a different project it runs recusively until it crashes

14:08:01  . prepare: > run-s 'prepare:**' generate
14:08:02  . prepare: WARN allowNonAppliedPatches is deprecated, use allowUnusedPatches instead.
14:08:02  . prepare: > @xx/yy@0.0.0-PLACEHOLDER prepare /var/jenkins/workspace/xx_renovate_npm-run-all2-8-x
14:08:02  . prepare: > run-s 'prepare:**' generate
14:08:03  . prepare: WARN allowNonAppliedPatches is deprecated, use allowUnusedPatches instead.
14:08:03  . prepare: > @xx/yy@0.0.0-PLACEHOLDER prepare /var/jenkins/workspace/xx_renovate_npm-run-all2-8-x
14:08:03  . prepare: > run-s 'prepare:**' generate
14:08:11  /usr/local/bin/node: line 19:    52 Killed                  /opt/containerbase/tools/node/22.15.1/bin/node "$@"
script returned exit code 137

[viceice]

I can confirm that v8.0.1 is working fine. so the minimatch<>picomatch swap is the reason.

v8.0.1...v8.0.2

[bcomnes]

Thanks for the report, will investigate when I get a moment. Please pin to 8.0.1 in the meantime.

[bcomnes]

Will be fixed in v8.0.3 shortly https://github.com/bcomnes/npm-run-all2/actions/runs/15143756571/job/42574269781

[viceice]

thank you

[bcomnes]

Sorry to bug again, but would you mind testing 8.0.4-beta.0 and let me know if you run into more issues?

[viceice]

8.0.4-beta.0 works for me

[bcomnes]

Thank you for confirming, and sorry for the noise.