-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: reverse buffers instead of strings #745
Conversation
This comment has been minimized.
This comment has been minimized.
Good find! |
Is it worth it to include a small benchmark in |
@braydonf Bench test added, results testing against master:
|
Looks like a 2 to 2 1/4 times faster, see about the same results. |
Was taking a look at when |
Okay, so it's not documented because |
Ok great, thanks for checking. was just going to add, |
Yeah, it's available from v4 and above (and possible some of the iojs releases in-between). |
util: reverse buffers instead of strings
This PR is just a cleanup from the recent buffers-instead-of-strings switchover.
Although these methods do not get called rapidly (they're mainly for JSON responses and API calls)
@BluSyn was able to observe a performance improvement: