validateaddress and getaddressinfo RPC Update

[tynes]

Overview

Update the node rpc method validateaddress to match the latest bitcoind interface.
The new interface is defined here: https://bitcoincore.org/en/doc/0.17.0/rpc/util/validateaddress/

Add the wallet rpc method getaddressinfo
https://bitcoincore.org/en/doc/0.17.0/rpc/wallet/getaddressinfo/

Notably, the properties ismine and iswatchonly are moved to getaddressinfo,
which is a good thing because in bcoin, validateaddress had them
hardcoded to false anyways, and we know of an exchange that
was attempting to use the value ismine for integrations into their system.
ismine now properly returns the correct value for addresses that
fall into the lookahead

Tests are added for p2pkh, p2sh, p2wpkh and p2wsh. I don't love that I had
to add undefined keys to the node-test.js file, but the undefined values
are being included in the object and other tests in the same file have hardcoded
undefined values as well. I think its because the objects aren't going over the
wire so the undefined values aren't being removed from the objects when
they get stringified

See changelog here: https://github.com/bitcoin/bitcoin/blob/53f26cd11dc04a0ab7a3ee72a3469050c4c2bc17/doc/release-notes/release-notes-0.17.0.md
See changes here: bitcoin/bitcoin#10583

Examples

Starting bitcoind with the command:

bitcoind -server -rest -regtest

And starting bcoin with the command:

bcoin --network regtest

getaddressinfo

p2pkh

bitcoind

$ bitcoin-cli -regtest getaddressinfo mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV
{
  "address": "mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV",
  "scriptPubKey": "76a9143a2d4145a4f098523b3e8127f1da87cfc55b8e7988ac",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false,
  "iswitness": false,
  "labels": [
  ]
}

bcoin

$ bwallet-cli --network regtest rpc getaddressinfo mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV
{
  "address": "mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV",
  "scriptPubKey": "76a9143a2d4145a4f098523b3e8127f1da87cfc55b8e7988ac",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false,
  "iswitness": false
}

p2sh

bitcoind

$ bitcoin-cli -regtest getaddressinfo 2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu
{
  "address": "2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu",
  "scriptPubKey": "a914ec7979ddc7ba13eefca73703c8a1da47eae965fa87",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true,
  "iswitness": false,
  "labels": [
  ]
}

bcoin

$ bwallet-cli --network regtest rpc getaddressinfo 2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu
{
  "address": "2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu",
  "scriptPubKey": "a914ec7979ddc7ba13eefca73703c8a1da47eae965fa87",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true,
  "iswitness": false
}

p2wpkh

bitcoind

$ bitcoin-cli -regtest getaddressinfo bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m
{
  "address": "bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m",
  "scriptPubKey": "00143a2d4145a4f098523b3e8127f1da87cfc55b8e79",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "3a2d4145a4f098523b3e8127f1da87cfc55b8e79",
  "labels": [
  ]
}

bcoin

$ bwallet-cli --network regtest rpc getaddressinfo bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m
{
  "address": "bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m",
  "scriptPubKey": "00143a2d4145a4f098523b3e8127f1da87cfc55b8e79",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "3a2d4145a4f098523b3e8127f1da87cfc55b8e79"
}

p2wsh

bitcoind

bitcoin-cli -regtest getaddressinfo bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253
{
  "address": "bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253",
  "scriptPubKey": "0020254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe",
  "labels": [
  ]
}

bcoin

$ bwallet-cli --network regtest rpc getaddressinfo bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253
{
  "address": "bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253",
  "scriptPubKey": "0020254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe"
}

validateaddress

p2pkh

bitcoind

$ bitcoin-cli -regtest validateaddress mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV
{
  "isvalid": true,
  "address": "mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV",
  "scriptPubKey": "76a9143a2d4145a4f098523b3e8127f1da87cfc55b8e7988ac",
  "isscript": false,
  "iswitness": false
}

bcoin

$ bcoin-cli --network regtest rpc validateaddress mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV
{
  "isvalid": true,
  "address": "mkpZhYtJu2r87Js3pDiWJDmPte2NRZ8bJV",
  "scriptPubKey": "76a9143a2d4145a4f098523b3e8127f1da87cfc55b8e7988ac",
  "isscript": false,
  "iswitness": false
}

p2sh

bitcoind

$ bitcoin-cli -regtest validateaddress 2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu
{
  "isvalid": true,
  "address": "2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu",
  "scriptPubKey": "a914ec7979ddc7ba13eefca73703c8a1da47eae965fa87",
  "isscript": true,
  "iswitness": false
}

bcoin

$ bcoin-cli --network regtest rpc validateaddress 2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu
{
  "isvalid": true,
  "address": "2NEoayrnYbRVSLmp1Y9buNsVGjWsU36Wagu",
  "scriptPubKey": "a914ec7979ddc7ba13eefca73703c8a1da47eae965fa87",
  "isscript": true,
  "iswitness": false
}

p2wpkh

bitcoind

$ bitcoin-cli -regtest validateaddress bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m
{
  "isvalid": true,
  "address": "bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m",
  "scriptPubKey": "00143a2d4145a4f098523b3e8127f1da87cfc55b8e79",
  "isscript": false,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "3a2d4145a4f098523b3e8127f1da87cfc55b8e79"
}

bcoin

$ bcoin-cli --network regtest rpc validateaddress bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m
{
  "isvalid": true,
  "address": "bcrt1q8gk5z3dy7zv9ywe7synlrk58elz4hrnegvpv6m",
  "scriptPubKey": "00143a2d4145a4f098523b3e8127f1da87cfc55b8e79",
  "isscript": false,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "3a2d4145a4f098523b3e8127f1da87cfc55b8e79"
}

p2wsh

bitcoind

$ bitcoin-cli -regtest validateaddress bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253
{
  "isvalid": true,
  "address": "bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253",
  "scriptPubKey": "0020254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe",
  "isscript": true,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe"
}

bcoin

$ bcoin-cli --network regtest rpc validateaddress bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253
{
  "isvalid": true,
  "address": "bcrt1qy48aglvtadmaerzngkedgswms528344p5jlvpahwvl5cgsxjtmlqcz0253",
  "scriptPubKey": "0020254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe",
  "isscript": true,
  "iswitness": true,
  "witness_version": 0,
  "witness_program": "254fd47d8beb77dc8c5345b2d441db851478d6a1a4bec0f6ee67e98440d25efe"
}

[tynes]

Realized I need to also update the CHANGELOG.md

Updated the CHANGELOG.md

[braydonf]

Looks good, a few minor nits. It's good to resolve those values from being hardcoded and sometimes incorrect values.The watchonly is defined by the wallet in bcoin, so the per address check doesn't completely map over, however good to have the value be correct.

[braydonf]

I also get an ischange property in the result from getaddressinfo in the 0.18 branch, worth including?