Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: link bclient to bin #707

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Conversation

pinheadmz
Copy link
Member

After installation, links bcoin-cli and bwallet-cli directly to bclient bin, already installed

@codecov-io

This comment has been minimized.

Copy link
Contributor

@braydonf braydonf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it will be nice to have the cli included as there really isn't much to do without an interface. It will also improve the process of installing, verifying and running a node. Examples can reference the cli without additional installation and verification steps.

@braydonf
Copy link
Contributor

braydonf commented Feb 21, 2019

nit: Could use a rebase on the latest master, and prepend bin: to the commit message for 009e7d3.

@pinheadmz
Copy link
Member Author

bin: prepended to commit message... as far as rebasing, aren't I on latest master here?

$ git log
commit c8db665992a8fe5a5b7a550b0e45ca957d030320 (HEAD -> bclient-bin-2, pinheadmz/bclient-bin-2)
Author: Matthew Zipkin <[email protected]>
Date:   Wed Feb 20 15:34:36 2019 -0800

    bin: fully deprecate bcoin cli

commit 08b23c177748a465559233bfcab08ee721fc22fe
Author: Matthew Zipkin <[email protected]>
Date:   Wed Feb 20 15:05:11 2019 -0800

    pkg: link bclient to bin

commit f585d8616df8335fddbc21d1b776a979ec6ff305 (origin/master, origin/HEAD, master)
Merge: 375965c8 f0023cb4
Author: Braydon Fuller <[email protected]>
Date:   Fri Feb 15 08:59:36 2019 -0800

    Merge pull request #470 nodar-chkuaselidze/fix/reject-cache

    fix malleability check in mempool

@tynes
Copy link
Member

tynes commented Feb 23, 2019

Can you add something to the changelog as well? This is a breaking change

@braydonf
Copy link
Contributor

As bclient also has the bin bcoin-cli and bwallet-cli the behavior of globally installing the bclient module will be replace bcoin-cli and bwallet-cli that was installed from the bcoin package, and vice versa. This likely isn't an issue.

@braydonf
Copy link
Contributor

@tynes I can also include in the changelog updates at #702 as it's not current with all the updates.

@braydonf braydonf merged commit c8db665 into bcoin-org:master Mar 1, 2019
braydonf added a commit that referenced this pull request Mar 1, 2019
@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants