Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update client-api example #667

Closed
wants to merge 1 commit into from

Conversation

pinheadmz
Copy link
Member

Updates a broken example in /docs brought to my attention by a user on slack:

https://github.com/bcoin-org/bcoin/blob/master/docs/Examples/client-api.js tutorial doesn't work for me. It writes Not enough funds. (available=0.0, required=0.0001078), but in logs I have Balance: { account: 1, tx: 1, coin: 4, unconfirmed: 201840, confirmed: 0 }.

Fixed:

@codecov-io
Copy link

codecov-io commented Jan 13, 2019

Codecov Report

Merging #667 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage    53.2%   53.33%   +0.12%     
==========================================
  Files         104      104              
  Lines       27724    27676      -48     
  Branches     4752     4738      -14     
==========================================
+ Hits        14751    14761      +10     
+ Misses      12973    12915      -58
Impacted Files Coverage Δ
lib/hd/hd.js 56.14% <0%> (-1.76%) ⬇️
lib/mempool/mempool.js 43.42% <0%> (-1.11%) ⬇️
lib/primitives/keyring.js 69.97% <0%> (-1%) ⬇️
lib/wallet/wallet.js 65.73% <0%> (-0.56%) ⬇️
lib/node/rpc.js 23.38% <0%> (-0.25%) ⬇️
lib/blockchain/chaindb.js 56.78% <0%> (-0.1%) ⬇️
lib/blockchain/chain.js 60.55% <0%> (-0.08%) ⬇️
lib/script/script.js 76.87% <0%> (-0.08%) ⬇️
lib/net/pool.js 15.87% <0%> (-0.05%) ⬇️
lib/wallet/walletdb.js 75.47% <0%> (-0.03%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375965c...61d6ee9. Read the comment docs.

@pinheadmz pinheadmz added the docs UI isn't clear or documented guidance needed label Jan 23, 2019
@pinheadmz
Copy link
Member Author

closing this, moving /docs project to #699

@pinheadmz pinheadmz closed this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs UI isn't clear or documented guidance needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants