mempool: reflect spent coins in mempool coinview. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodech
force-pushed
the
fix/mempool-index
branch
from
1ceb9f4 to
cd83f21
Compare
Currently coinview does not account for spent coins in the mempool, This does not create problems because we have additional checks in right places which detect double spends, but technically coinview should help you detect double spent in the mempool as well. This way it will be compatible with chain.getCoinView. getSpentView will still return all outputs that are available in the mempool. (This could also return spentView from indexers if available, this method is used by `signrawtransaction`.)
nodech
force-pushed
the
fix/mempool-index
branch
from
cd83f21 to
32cba1b
Compare
tuxcanfly
approved these changes
Dec 6, 2018
|
|
||
| await mempool.addTX(tx2); | ||
|
|
||
| // we should not have coins available in the mempool for these txs. |
There was a problem hiding this comment.
maybe a small comment explaining that
getCoinView: returns unspent coins only
getSpentView: returns spent + unspent coins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently coinview does not account for spent coins in the mempool,
This does not create problems because we have additional checks in
right places which detect double spends, but technically
coinview should help you detect double spent in the mempool as well.
This way it will be compatible with chain.getCoinView.
getSpentView will still return all outputs that are available
in the mempool. (This could also return spentView from indexers if
available, this method is used by
signrawtransaction.)