Wallet: require public key for watchonly #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=========================================
+ Coverage 53.18% 53.2% +0.02%
=========================================
Files 104 104
Lines 27724 27724
Branches 4752 4752
=========================================
+ Hits 14745 14751 +6
+ Misses 12979 12973 -6
Continue to review full report at Codecov.
|
tuxcanfly
approved these changes
Jan 1, 2019
|
Added note in changelog, will update API docs after merge |
pinheadmz
added
tests
braydonf
reviewed
Feb 9, 2019
braydonf
approved these changes
Feb 11, 2019
braydonf
added a commit
that referenced
this pull request
Feb 11, 2019
Wallet: require public key for watchonly
|
Merged in 375965c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #636 in which a user creates private keys they could never access due to a wallet being watch-only.
This PR goes along with #637 and bcoin-org/bclient#15, maybe we can decide if we need all three safeties in place or which ones we do or don't need.
In this pull request, we prevent a watch-only wallet from ever generating a master (private) key which could lead to a user seeing addresses they can not spend from.
I think
watchOnlyshould always require anaccountKey. The reverse isn't necessarily required, for example inbclient, creating a wallet withaccountKeyautomatically setswatchOnlytotrue. In bcoinwallet._createAccount(),accountKeyis just ignored ifwatchOnlyis false, but at least that doesn't lead to unrecoverable keys!