Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address minor fixes #632

Merged
merged 1 commit into from
Jan 4, 2019
Merged

address minor fixes #632

merged 1 commit into from
Jan 4, 2019

Conversation

nodech
Copy link
Member

@nodech nodech commented Nov 15, 2018

Minor fixes

Related PRs: #581, #612

@codecov-io

This comment has been minimized.

* @returns {Hash}
*/

static getHash(data, network) {
static getHash(data, enc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not being used anywhere atm, right?

Copy link
Member

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tuxcanfly tuxcanfly merged commit bd7a094 into bcoin-org:master Jan 4, 2019
@nodech nodech deleted the fix/addresses branch June 28, 2019 08:26
@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants